Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of starter pack records #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Dec 6, 2024

Addresses #16

This should work!

Screenshot 2024-12-05 at 5 56 24 PM

@jaseemabid
Copy link
Owner

I'm not sure if this is actually needed since it works fine for me without. These are the values I have btw.

export STARTER_PACK_URI='at://did:plc:r2klcx26ygxty7yprmbtd7b5/app.bsky.graph.list/3lagxhsxcma2e'
export LIST_URI='at://did:plc:r2klcx26ygxty7yprmbtd7b5/app.bsky.graph.list/3lawghh5a6v2c'

Maybe your URI is pointing to the top level starter pack and not the list inside it? Will have to dig a bit more into the details later to be sure.

@patcon
Copy link
Contributor Author

patcon commented Dec 6, 2024

ah yes, i pointed it to the starter pack uri, which is what is visible in the url, and most easily discoverable for setup

what if i parsed for app.bsky.graph.starterpack in the uri instead?

Sorry, I am def submitting PRs as if you're open to this being used by others as a general tool, and want a good experience for users in that situation. but if this isn't up you alley, i can just create a "detached fork" (forks don't show up easily in search, and so aren't geared toward being standalone projects)

@patcon patcon force-pushed the 16-fix-starter-pack-update branch from 5f50ded to f85aa8a Compare December 6, 2024 20:10
@patcon
Copy link
Contributor Author

patcon commented Dec 6, 2024

K, handling this more generally now. Lemme know if it works for you :)

@patcon
Copy link
Contributor Author

patcon commented Dec 6, 2024

To be clear, this PR allows starter packs to be specified more conveniently from looking at the web url:

#export STARTER_PACK_URI='at://did:plc:r2klcx26ygxty7yprmbtd7b5/app.bsky.graph.list/3lagxhsxcma2e'
export LIST_URI='at://did:plc:r2klcx26ygxty7yprmbtd7b5/app.bsky.graph.list/3lawghh5a6v2c'

# Source starter pack -->  https://bsky.app/starter-pack/jabid.in/3lagxhtghxi2e
export STARTER_PACK_URI='at://jabid.in/app.bsky.graph.starterpack/3lagxhtghxi2e'

note the last at-uri part matching the source web url, and the non-requirement of figuring out the DID

Disclaimer: For some reason, unlike get_starter_pack, get_list doesn't allow the handle-style at-uri as the scheme spec says it should, only the DID-style. I'm filing a bug for that upstream, and will link it here after, for context.

A DID-style at-uri is supposed to be the more permanent and recommended option (to persist beyond handle changes), but shouldn't be required.

@patcon
Copy link
Contributor Author

patcon commented Dec 7, 2024

Added some docs too, so it's clear which values will work. Should I add sample values to show that sub-list uri's work for starter packs, or is that just kinda tedium now (since not required)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants