Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-20168 update xulrunner to build w/ latest Tycho 0.22 and parent pom 4.3.0.Beta2 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JBIDE-20168 update xulrunner to build w/ latest Tycho 0.22 and parent pom 4.3.0.Beta2 #15

wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Member

No description provided.

@nickboldt nickboldt changed the title update xulrunner to build w/ latest Tycho 0.2... ...2 and parent pom 4.3.0.Beta2 JBIDE-20148 update xulrunner to build w/ latest Tycho 0.22 and parent pom 4.3.0.Beta2 Jun 30, 2015
@nickboldt nickboldt changed the title JBIDE-20148 update xulrunner to build w/ latest Tycho 0.22 and parent pom 4.3.0.Beta2 JBIDE-20168 update xulrunner to build w/ latest Tycho 0.22 and parent pom 4.3.0.Beta2 Jun 30, 2015
@nickboldt
Copy link
Member Author

Note! this build only produces 4 plugins in the update site, so something is CLEARLY WRONG. DO NOT MERGE until I can figure out what's wrong and why we have no osx or linux plugins.

org.mozilla.xpcom_1.9.2.16.jar
org.mozilla.xpcom.source_1.9.2.16.jar
org.mozilla.xulrunner.win32.win32.x86_1.9.2.16b.jar
org.mozilla.xulrunner.win32.win32.x86.source_1.9.2.16b.jar

maxandersen
maxandersen reviewed Jul 1, 2015
View reviewed changes
features/org.mozilla.xulrunner.feature/pom.xml
@@ -26,6 +26,11 @@
</goals>
</execution>
</executions>
<configuration>
<excludes>
<plugin id="org.mozilla.xulrunner.cocoa.macosx"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you adding this exclude ? That could explain why you are not getting osx stuff built.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause we do have only x86 builded xulrunner for OSX. So we don't need OSX xulrunner bundles.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it doesn't explain why the Linux stuff is missing. :{

I added the exclude to the source-feature goal because the source feature build was failing to find sources for o.m.x.cocoa.macosx. It should not prevent the BUILDING of the plugins, only the autogen of the source plugins in the source feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickboldt @maxandersen @kmarmaliykov