fix: remove basedir in resolveOptions, allow original NodeJS resolve algorithm #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix #233.
Allow NodeJS original
node_module
algorithm to be used by@esbuild-plugins/node-resolve
/resolve
.Why:
#68 specified basedir to
cwd
which causes allnode_modules
resolution to start atcwd
. This prevent nestednode_modules
to ever be resolved. See #233Below illustrate the incorrect search paths when
basedir
is mapped tocwd
How:
By removing
resolveOptions.basedir
, it allow@esbuild-plugins/node-resolve
/resolve
to use the default NodeJSnode_modules
resolve algorithm wherenode_modules
resolution starts from the directory of the caller module.Below illustrate the correct search paths
Checklist: