-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: feat(jsx): base for supporting more runtimes #236
base: main
Are you sure you want to change the base?
Conversation
cb27722
to
b301a41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think I want to lowercase a few things. Other than that, this is perfect :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One last thing. Could you add a note about this in the readme?
Of course! Still have to do few things though:
|
Co-authored-by: Kent C. Dodds <[email protected]>
fe0c597
to
3dcb9ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What:
Support JSX runtimes other than react.
Why:
Allow this to be used with other JSX runtimes supported by mdxjs (https://mdxjs.com/docs/getting-started/#jsx) but not limited to. For example, this can work quite fine with https://hono.dev/ too, eventhough it's not mentioned here (thanks to a fact, that Hono is compatible with React's API)
How:
Adjust
bundleMDX
to accept jsxConfig (which fallbacks to react).getMDXComponent
will have to be adjusted too, still looking for an approach which would have least breaking changes. Second paramterglobals
could be used for that, as such:Checklist:
Todo: