Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip install in python based action step #227

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Oct 14, 2024

Changes

  • Fix pip install in python based action step

Related to:
knative/infra#530

/cc @upodroid @skonto @cardil

@knative-prow knative-prow bot requested review from cardil, skonto and upodroid October 14, 2024 08:44
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
@skonto
Copy link
Contributor

skonto commented Oct 14, 2024

/lgtm
/approve

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

knative-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ReToCode,dsimansk,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member

/hold cancel
/override "Lint / style / suggester / yaml (pull_request)"

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
Copy link

knative-prow bot commented Oct 14, 2024

@upodroid: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Lint / style / suggester / yaml (pull_request)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/hold cancel
/override "Lint / style / suggester / yaml (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upodroid
Copy link
Member

/override "style / suggester / yaml"

Copy link

knative-prow bot commented Oct 14, 2024

@upodroid: Overrode contexts on behalf of upodroid: style / suggester / yaml

In response to this:

/override "style / suggester / yaml"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit d5f6201 into knative:main Oct 14, 2024
7 of 8 checks passed
@dsimansk dsimansk deleted the pr/fix-python-action branch October 15, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants