Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed path-to-regex to ^8.0.0 #75

Closed
wants to merge 3 commits into from
Closed

Conversation

dudek824
Copy link

@dudek824 dudek824 commented Oct 1, 2024

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@dudek824 dudek824 marked this pull request as ready for review October 1, 2024 19:14
Copy link
Author

@dudek824 dudek824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help review, don't understand the error generated.

@rnwalker7
Copy link

Suggest changing path-to-regexp to 6.3.0 instead of 8.0.0 for the interim. 8.0.0 will require a lot of rework, as it no longer accepts "()" or "[]". 6.3.0 will clear up CVE-2024-45296.

@dudek824 dudek824 closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants