[DRAFT WORK IN PROGRESS] Adding VirtioFS #995
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flintlock-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
richardcase
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Great work @steve-fraser 🎉 Please don't be put off by the number of comments. Let me know if i can help with anything.
core/application/commands.go
Outdated
| if mvm.Spec.RootVolume.Source.VirtioFS != nil { | ||
| return nil, fmt.Errorf("VirtioFS is not available yet for RootVolume") | ||
| } | ||
| if len(mvm.Spec.AdditionalVolumes) > 0 { |
There was a problem hiding this comment.
Its probably worth checking as well that if volume.Source.VirtioFS is specified that the microvm provider has the capability.
richardcase
reviewed
Dec 31, 2024
Co-authored-by: Richard Case <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: