-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove use of http2_server in replicator aws proxy #62
base: main
Are you sure you want to change the base?
Conversation
8e0e63f
to
49b5a01
Compare
May not have been that easy after all. Will investigate further.. |
48823d3
to
815d7b2
Compare
I tried to re-write the entire proxying mechanism by re-using more from our handler chain, but there still seem to be several issues related to headers and streaming data, which I think is a result of the proxy mechanism on both sides doing too many things to the request. I need to sit down with @whummer to better understand what the components should be doing exactly before moving forward, because I'm shotgun debugging at this point. |
Thanks for digging into this @thrau and getting the extension upgraded to the new gateway logic! 🙌 Happy to do some pairing on this - or maybe I'll find some time this weekend to dig into it a bit.. Let's compare notes soon! |
815d7b2
to
4e8aed0
Compare
@thrau Sorry for the delay, finally got a chance to look into this. Great job on the refactoring and removing the use of Was running some quick tests locally, seems to be working. 🎉 At least for S3 requests - these buckets are proxied from a real AWS account:
SQS tests still seem to be failing in the CI pipeline, we can look into those next.. 👀 |
4e8aed0
to
4034ff4
Compare
Motivation
🚧
Fixes #45
This is an attempt to move away from the http2_server implementation, by replacing the current auth proxy implementation with a handler chain.
Changes