Dont's squash - gradient updates #7646
Open
+1,057
−425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuNeo
reviewed
Jan 23, 2025
| @@ -34,7 +34,7 @@ struct _lv_vector_path_t { | |||
|
|
|||
| struct _lv_vector_gradient_t { | |||
| lv_vector_gradient_style_t style; | |||
| lv_gradient_stop_t stops[LV_GRADIENT_MAX_STOPS]; /**< A gradient stop array */ | |||
| lv_grad_stop_t stops[LV_GRADIENT_MAX_STOPS]; /**< A gradient stop array */ | |||
There was a problem hiding this comment.
Need to align with below line.
|
|
||
| #if LV_USE_DRAW_SW_COMPLEX_GRADIENTS | ||
|
|
||
| void lv_grad_linear_init(lv_grad_dsc_t * dsc, int32_t from_x, int32_t from_y, int32_t to_x, int32_t to_y, |
There was a problem hiding this comment.
Should from_x and from_y be lv_point_t from? This way the LV_USE_FLOAT will also work.
|
|
||
| /** A descriptor of a gradient. */ | ||
| typedef struct { | ||
| lv_grad_stop_t stops[LV_GRADIENT_MAX_STOPS]; /**< A gradient stop array */ |
There was a problem hiding this comment.
Need to align with below line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend trying out
lv_example_grad_2/3/4(). They are really nice. 😊cc @zjanosy
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.