Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): camel case event handlers were incorrect #2044

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

LuLaValva
Copy link
Member

Description

  • Flattened camels

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: 84611cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva changed the title fix(typescript): demote all event handler camels to a single hump fix(typescript): camel case event handlers were incorrect Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (55ea759) 84.94% compared to head (84611cf) 84.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2044   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files         225      225           
  Lines       18723    18723           
=======================================
  Hits        15904    15904           
  Misses       2819     2819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 358fb2d into main Oct 16, 2023
@DylanPiercey DylanPiercey deleted the event-handler-lowercase branch October 16, 2023 23:41
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants