Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legacy compatibility issue with esm templates and defineWidget #2053

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes an issue where if the require('marko-component').defineComponent is passed a template which is compiled in esm mode.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 56c3898

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 37b347e into main Nov 10, 2023
7 checks passed
@DylanPiercey DylanPiercey deleted the fix-widget-compat-esmodule branch November 10, 2023 17:28
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant