Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic await tag ssr #2458

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Basic await tag ssr #2458

merged 2 commits into from
Jan 9, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 7b2b38e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 76b3083 into main Jan 9, 2025
8 checks passed
@DylanPiercey DylanPiercey deleted the basic-await-tag-ssr branch January 9, 2025 17:18
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 84.34505% with 49 lines in your changes missing coverage. Please review.

Project coverage is 87.18%. Comparing base (5cc3648) to head (7b2b38e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/translator/core/await.ts 79.24% 33 Missing ⚠️
packages/runtime-tags/src/translator/core/try.ts 89.28% 12 Missing ⚠️
packages/runtime-tags/src/html/writer.ts 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
- Coverage   87.20%   87.18%   -0.03%     
==========================================
  Files         348      350       +2     
  Lines       39546    39847     +301     
  Branches     2560     2577      +17     
==========================================
+ Hits        34488    34740     +252     
- Misses       5032     5081      +49     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant