Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-ai-luis #4824

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR removes the unnecessary eslint.config file to reference the root one directly in the botbuilder-ai-luis project. No ESLint warnings or errors found.

Specific Changes

  • Removed 'only-warn' plugin from 'botbuilder-ai-luis'.

Testing

The following image shows that there are no more ESLint issues.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner December 20, 2024 13:06
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12431975493

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 1fe90aa into main Jan 6, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-ai-luis branch January 6, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants