Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in botbuilder-dialogs #4832

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

JhontSouth
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new errors and warnings incoming in the latest version of ESLint packages in botbuilder-dialogs.

Specific Changes

  • Removed eslint.config.cjs file.
  • Fixed ESLint issues by running --fix flag.
  • Added missing documentation and removed unnecessary spaces.
  • Added some skips to rules that don't follow the current logic.
  • Removed duplicated unit test and combined logic of these two.

Testing

The following image shows the lint command running without problems in botbuilder-dialogs.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 20, 2024 17:27
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12435761505

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 84.624%

Totals Coverage Status
Change from base Build 12259066809: -0.001%
Covered Lines: 20512
Relevant Lines: 23090

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 5464ddd into main Jan 6, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-issues-botbuilder-dialogs branch January 6, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants