test: attempt to unflake highlight-locators.spec

microsoft · Jan 10, 2025 · 44d0429 · 44d0429
1 parent 059dd1a
commit 44d0429
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/debugHighlight.ts b/src/debugHighlight.ts
@@ -114,9 +114,13 @@ export class DebugHighlight {
   }
 
   private async _highlightLocator(document: vscodeTypes.TextDocument, position: vscodeTypes.Position, token?: vscodeTypes.CancellationToken) {
-    if (!this._reusedBrowser.pageCount())
+    console.log(`debugHighlight._highlightLocator`);
+    if (!this._reusedBrowser.pageCount()) {
+      console.log(`debugHighlight._highlightLocator: no pages!`);
       return;
+    }
     const result = await locatorToHighlight(this._debugSessions, document, position, token);
+    console.log(`debugHighlight._highlightLocator: ${result}`);
     if (result)
       this._reusedBrowser.highlight(result).catch(() => {});
     else

diff --git a/tests/highlight-locators.spec.ts b/tests/highlight-locators.spec.ts
@@ -23,6 +23,8 @@ test.beforeEach(({ showBrowser }) => {
 });
 
 test('should work', async ({ activate }) => {
+  test.slow();
+
   const cdpPort = 9234 + test.info().workerIndex * 2;
   const { vscode, testController } = await activate({
     'playwright.config.js': `module.exports = {
@@ -90,15 +92,13 @@ test('should work', async ({ activate }) => {
       [[17, 30], boxOne],
     ] as const) {
       await test.step(`should highlight ${language} ${line}:${column}`, async () => {
-        // Clear highlight.
-        vscode.languages.emitHoverEvent(language, vscode.window.activeTextEditor.document, new vscode.Position(0, 0));
-        // Let highlight poll update its state.
-        await new Promise(f => setTimeout(f, 500));
         vscode.languages.emitHoverEvent(language, vscode.window.activeTextEditor.document, new vscode.Position(line, column));
+        // Let highlight poll update its state.
+        await new Promise(f => setTimeout(f, 1500));
         if (!expectedBox) {
-          await expect(page.locator('x-pw-highlight')).toBeHidden();
+          await expect(page.locator('x-pw-highlight')).toBeHidden({ timeout: 10000 });
         } else {
-          await expect(page.locator('x-pw-highlight')).toBeVisible();
+          await expect(page.locator('x-pw-highlight')).toBeVisible({ timeout: 10000 });
           expect(await page.locator('x-pw-highlight').boundingBox()).toEqual(expectedBox);
         }
       });