Remove the openssl-devel package from dependencies #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynzech
approved these changes
Jan 24, 2025
|
I tried to dig in this history to figure out why it was added, but couldn't see an obvious reason. It might be because CBMC installs it as part of its build process: @adpaco-aws, do you know? |
|
I can't remember, and the only reason I can think of is that the dependency may have been missing from a certain kind of AL2 instances. But there's no reason to keep if it's been tested. |
feliperodri
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirmed the
openssl-develpackage is not needed to build Kani using fresh AL2 instances (bothaarch64andx86_64).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.