Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sandbox requirements installation from Dockerfile #530

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Remove sandbox requirements installation from Dockerfile #530

merged 1 commit into from
Jan 7, 2025

Conversation

HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Jan 6, 2025

As the title says.

@HYLcool HYLcool added dj:ci/cd issues/PRs about CI/CD of Data-Juicer environment related to third-party dependency, DJ-pypi, DJ-docker, etc. labels Jan 6, 2025
@HYLcool HYLcool requested review from BeachWang and yxdyc January 6, 2025 12:43
@HYLcool HYLcool self-assigned this Jan 6, 2025
BeachWang
BeachWang approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@BeachWang BeachWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yxdyc
yxdyc approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for now, we do not need to include (potentially heavy) env for sandbox into our CI/CD workflow.

@HYLcool HYLcool merged commit 8cbd336 into main Jan 7, 2025
4 checks passed
@HYLcool HYLcool deleted the fix/sandbox_image branch January 7, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxdyc yxdyc yxdyc approved these changes

@BeachWang BeachWang BeachWang approved these changes

Assignees

@HYLcool HYLcool

Labels
dj:ci/cd issues/PRs about CI/CD of Data-Juicer environment related to third-party dependency, DJ-pypi, DJ-docker, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HYLcool @BeachWang @yxdyc