Check that the bottom PR is mergeable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub lets you check if a PR is actually mergeable via the `gh` CLI by retrieving the `mergeStateStatus` field. This field has a bunch of values (see the [API documentation][1] linked below), but the one we care about is `CLEAN`, indicating that the PR has no merge conflicts and has passed PR checks. I'd like to eventually add this information to `stack-pr view`, but it will require some extra piping, and will slow down the command due to the extra network request. 1: https://docs.github.com/en/graphql/reference/enums#mergestatestatus
ZolotukhinM
approved these changes
Aug 24, 2024
| @@ -424,7 +431,7 @@ def set_base_branches(st: List[StackEntry], target: str): | |||
|
|
|||
| def verify(st: List[StackEntry], check_base: bool = False): | |||
| log(h("Verifying stack info"), level=1) | |||
| for e in st: | |||
| for index, e in enumerate(st): | |||
There was a problem hiding this comment.
index doesn't seem to be used here, do we need this particular change?
There was a problem hiding this comment.
It's used to test mergeability against only the bottom-most PR.
There was a problem hiding this comment.
Oh, sorry, my bad, I didn't realize the change below is in the same loop :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub lets you check if a PR is actually mergeable via the
ghCLI byretrieving the
mergeStateStatusfield. This field has a bunch ofvalues (see the [API documentation][1] linked below), but the one we care
about is
CLEAN, indicating that the PR has no merge conflicts and haspassed PR checks.
I'd like to eventually add this information to
stack-pr view, but it willrequire some extra piping, and will slow down the command due to the
extra network request.
1: https://docs.github.com/en/graphql/reference/enums#mergestatestatus