Versions refactor 2 #1204
Merged
Versions refactor 2 #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
force-pushed
the
versions-refactor-2
branch
2 times, most recently
from
b0377f0 to
1f6e9fc
Compare
|
can be done step by step. |
andrzejj0
force-pushed
the
versions-refactor-2
branch
from
1f6e9fc to
a3902b9
Compare
|
Rebased. One remark: because the goal now shares the common base with other similar goals, which don't print such information, we are now also not logging INFO lines like:
so I had to remove a check for that line from one of the it tests. |
slawekjaranowski
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second stage of the other PR, adding UpdateParent to the common base: I've noticed that updating parent is already being done by Use-*-*, but it used a different method. So why don't we refactor it even further? The goal is to make the plugin codebase smaller.
Also, here I have replaced
is...getters byget...for booleans as they were not always grammatical and not always consistent (isProcessing...which differs from the name of the field).Edit: added a comment: with skipResultion == false, this goal is a slightly modified use-*-* targeting parent only, with an added modification that it also has the
parentVersionparameter.Maybe I should just merge this PR into the other one and create one big PR instead?