Add GitHub workflow to check PRs' diff size with Danger #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
changed the base branch from
develop
to
danger-local-setup-label-and-consistency-checks
mokagio
force-pushed
the
danger-local-setup-label-and-consistency-checks
branch
from
7ba11c1 to
461638a
Compare
mokagio
force-pushed
the
danger-local-setup-diff-size
branch
2 times, most recently
from
edea48f to
fd0df8e
Compare
mokagio
changed the base branch from
danger-local-setup-label-and-consistency-checks
to
danger-all-in-one-workflow-ready-for-trunk
mokagio
force-pushed
the
danger-all-in-one-workflow-ready-for-trunk
branch
from
f886cc0 to
5863010
Compare
mokagio
force-pushed
the
danger-local-setup-diff-size
branch
from
566d0e1 to
ba105d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, I based this PR off
danger-all-in-one-workflow-ready-for-trunk(wordpress-mobile#13535) to make it easier to review. I won't change the base branch or open a PR against trunk till the rest of the work has been merged.Follows up on the wordpress-mobile#13366 work by migrating the diff size check to Danger + GitHub workflow (see
diff-size.ts).To test this, I made a commit with 500 new line, and verified Danger posted a warning comment:
Once the commit is reverted and the diff size goes to less than 500 lines, Danger removes the comment: