Setup DangerJS via GitHub Action and run Peril rule to check Issues labels #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to see if the Danger JS integration works, as there isn't any other way to do so 😞 . |
mokagio
force-pushed
the
danger-js-setup
branch
from
51f38d6 to
9a599b2
Compare
mokagio
force-pushed
the
danger-js-setup
branch
from
9a599b2 to
9bd6e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #2 and integrates the Danger JS Action to run the action to check the labels of an Issue from the peril-settings repo.
I like the standalone setup. This way, we wouldn't need to manage yarn or even add rules to WordPress mobile repo.
I do wonder though if it'd be possible to version the file to run, so that we only upgrade it intentionally. In other words, I'd like to avoid a change in the rule made for the sake of one repo breaking the behavior on other repos. 🤔 ... I guess this is a tradeoff to explore, is centralized management worth the risk?
To test, see #1.