Bumped edireader library version, upgraded processor bundle version to be independent from Nifi version, fixed tests on Windows, fixed static analysis code unconventional #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 14, 2024 12:31
…version Version of the processor must be different from nifi version as it should follow a different flow based on changes on this component. Processor depends also on a edireader library that is independent from Nifi. Re-starting from version 2.0.0 to include changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped edireader library version
Berryworks edireader version has been upgraded from 5.4.17 to 5.6.5. This allows the developer to be in line with the latest version as 5.4.17 is not a tagged version and doesn't allow to package the processor. Version 5.6.5 hasn't been released yet, but I hope it will be soon, otherwise, it is also possible to use the last available tagged versions (5.6.0 or 5.6.4). In this way, the processor can reference an updated library and it can be built in case of any patch / bug / enhancement.
Upgraded processor bundle version to be independent of NiFi version
The processor version must be independent of the Nifi version as it also has other dependencies. The component bundle version should be managed when there are new changes to the repository (bug fixes, dependency upgrades, enhancements). Still better to use "-SNAPSHOT" version to consider a development version not released yet.
IMHO, it is better to re-start from a higher version to avoid incompatibility, so I moved to 2.0.0.
Example: The developer would like to upgrade berryworks edireader version without bumping Nifi version. It can be possible by structuring the component version as independent wrt the Nifi version.
Fixed tests on Windows
Tests are now working on Windows platform as well as Linux / Mac. It is now possible to build and package the component processor on Windows as well. It fixes the issue: #10 .
Fixed static analysis code unconventional
Closed scanner at the end of the loop, added explicit types on Java Map, removed unused imports.
Testing
The testing phase has been performed on Windows and Mac for the building phase, on Nifi 1.23.2 to test the component (backward compatibility). Nifi has been deployed on a clusterized environment using helm (https://github.com/cetic/helm-nifi) with version 1.2.0. EDIs have been parsed correctly as the same as the latest released processor version (1.9.2).
For any questions, feel free to contact me:
Lorenzo Vangi
[email protected]
[email protected]
Looking forward to hearing from you,
Regards.