Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual changes to DGL source for hipification #10

Open
wants to merge 2 commits into
base: hip-ready
Choose a base branch
from

Conversation

GMNGeoffrey
Copy link
Collaborator

@GMNGeoffrey GMNGeoffrey commented Jan 18, 2025

These changes are on the original DGL source code. These plus running script/hipify-inplace.sh yields the hipified version of DGL which is identical to the code currently in #9. The version in this commit should still run with CUDA.

This obviously shouldn't be merged into the same branch as PRs #1 through #9. The idea is that this would be the PR we would need for upstream (although I'm guessing they would actually want it in smaller chunks).

These changes are on the original DGL source code. These plus running
~/script/hipify-inplace.sh should yield the hipified version for running
on ROCM. This version should still run with CUDA.
I'm not sure how this got unset. I've had issues with git unsetting this
before though.
@GMNGeoffrey
Copy link
Collaborator Author

@jeffdaily FYI. I don't think there's really much to review in the code here. I've confirmed that this + the hipify scripting yields the source in #9

@GMNGeoffrey GMNGeoffrey requested a review from jeffdaily January 22, 2025 18:04
@GMNGeoffrey GMNGeoffrey changed the base branch from master to hip-ready January 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant