-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix invalid common.mustSucceed() usage #56756
Open
lpinca
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
lpinca:fix/invalid-common-must-succeed-usage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+48
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By its own nature, the function returned by `common.mustSucceed()` cannot be used as a listener for `'error'` events. Write errors like `read ECONNRESET` or `write EPIPE`, should be ignored because the socket might be closed by the other peer while the request is sent. Refs: nodejs@3caa2c1a005652fdb3e8
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Jan 25, 2025
This should address the following failure
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 25, 2025
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jan 25, 2025
Reduce chances of write errors while the request is sent. Refs: nodejs#56756
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56756 +/- ##
=======================================
Coverage 89.20% 89.21%
=======================================
Files 662 662
Lines 192124 192124
Branches 36972 36976 +4
=======================================
+ Hits 171390 171406 +16
+ Misses 13559 13549 -10
+ Partials 7175 7169 -6 |
jasnell
approved these changes
Jan 25, 2025
RafaelGSS
approved these changes
Jan 25, 2025
aduh95
approved these changes
Jan 25, 2025
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By its own nature, the function returned by
common.mustSucceed()
cannot be used as a listener for'error'
events.Write errors like
read ECONNRESET
orwrite EPIPE
, should be ignored because the socket might be closed by the other peer while the request is sent.Refs: 3caa2c1a005652fdb3e8