child_process: validate options.shell and correctly enforce shell invocation in exec/execSync #56761
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- narrow validation type to string (previously de facto not validated) - ensure empty string is coerced to true - add test cases for options.shell
nodejs-github-bot
added
child_process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56761 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 662 662
Lines 192124 192129 +5
Branches 36980 36976 -4
==========================================
+ Hits 171404 171407 +3
- Misses 13552 13558 +6
+ Partials 7168 7164 -4
|
aduh95
reviewed
Jan 25, 2025
Comment on lines
+203
to
+204
| } | ||
| options.shell ||= true; |
There was a problem hiding this comment.
I don't understand why would we want to accept the empty string a valid value
Suggested change
| } | |
| options.shell ||= true; | |
| } else { | |
| options.shell = true; | |
| } |
There was a problem hiding this comment.
The sister functions spawn/execFile validate shell: '' as valid, and their behaviour then becomes the same as passing false or undefined.
This PR makes exec's behaviour the same as these, but the empty string needs to be coerced to true just the same as nullish values, otherwise the default shell won't be spawned (as per the logic outlined in the previous PR's description).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously opened as #54623, and the PR description there is still valid. Unfortunately this was originally submitted while CI was blocked by the macos test platform issues, and never made it back to request-ci.