Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from travis to github ci. #119

Closed
wants to merge 1 commit into from
Closed

Conversation

TkTech
Copy link

@TkTech TkTech commented Jan 24, 2021

I needed to fix the tests for #118, since ci is failing. But the CI is using travis-ci.org, which is a dead man walking and will disappear in the next few days. So this:

  • Switches from travis-ci.org to GitHub actions (however there is a branch that fixes travis here if you really want to stick with it.)
  • Switches the test runner from unittest to pytest. It's compatible, and the test output is actually sane.
  • Add py3.7 to py3.9 to tests.
  • One test still fails before and after this change, which I haven't had a chance to look at but is probably from a change to M2Crypto if I had to hazard a guess.

While working on this, I noticed the manifest tools aren't handling newlines properly which break a number of tests for me on *nix. For example the *.mf files are using \r\n, but the tests don't normalize line endings when reading from the pipe, ex: https://github.com/obriencj/python-javatools/blob/master/tests/jarutil.py#L146 which should be NamedTemporaryFile('rt') on py3 and NamedTemporaryFile('rtU') on py2.7.

@KonstantinShemyak
Copy link
Contributor

While working on this, I noticed the manifest tools aren't handling newlines properly which break a number of tests for me on *nix. For example the *.mf files are using \r\n, but the tests don't normalize line endings when reading from the pipe

@TkTech interesting, I'm running tests on Linux and getting no failures. Also, I don't see U option for NamedTemporaryFile in Python 2.7? Would you kindly file a bug?

@obriencj
Copy link
Owner

obriencj commented Jul 7, 2023

did eventually switch to actions, but using tox-gh-actions

@obriencj obriencj closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants