Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to fix the tests for #118, since ci is failing. But the CI is using travis-ci.org, which is a dead man walking and will disappear in the next few days. So this:
While working on this, I noticed the manifest tools aren't handling newlines properly which break a number of tests for me on *nix. For example the *.mf files are using
\r\n
, but the tests don't normalize line endings when reading from the pipe, ex: https://github.com/obriencj/python-javatools/blob/master/tests/jarutil.py#L146 which should beNamedTemporaryFile('rt')
on py3 andNamedTemporaryFile('rtU')
on py2.7.