[pkg/ottl] introduce FormatTime() converter function #37112
+311
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
odubajDT
force-pushed
the
ottl-timestamp
branch
from
e4a3e0b to
22d9292
Compare
TylerHelmuth
reviewed
Jan 9, 2025
odubajDT
force-pushed
the
ottl-timestamp
branch
from
22d9292 to
e7aa7d2
Compare
odubajDT
changed the title
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
ottl-timestamp
branch
from
e7aa7d2 to
aee7584
Compare
edmocosta
reviewed
Jan 10, 2025
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Signed-off-by: odubajDT <[email protected]>
evan-bradley
approved these changes
Jan 10, 2025
| args, ok := oArgs.(*FormatTimeArguments[K]) | ||
|
|
||
| if !ok { | ||
| return nil, fmt.Errorf("FormatTimeFactory args must be of type *FormatTimeArguments[K]") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("FormatTimeFactory args must be of type *FormatTimeArguments[K]") | |
| return nil, errors.New("FormatTimeFactory args must be of type *FormatTimeArguments[K]") |
Nitpick, but we don't need fmt.Errorf here since the entire string is static.
|
|
||
| func FormatTime[K any](timeValue ottl.TimeGetter[K], format string) (ottl.ExprFunc[K], error) { | ||
| if format == "" { | ||
| return nil, fmt.Errorf("format cannot be nil") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("format cannot be nil") | |
| return nil, errors.New("format cannot be nil") |
Same here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
FormatTime(time, format)converter to convert any time to a human readable string with the specified formatLink to tracking issue
Fixes #36870