[chore] Spelling #37128
Draft
[chore] Spelling #37128
+1,398
−1,416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
github-actions
bot
added
exporter/clickhouse
exporter/coralogix
exporter/datadog
jsoref
commented
Jan 10, 2025
atoulme
reviewed
Jan 10, 2025
| @@ -150,7 +150,7 @@ type DispatchArtifactContent struct { | |||
| ScheduledCount string `json:"scheduled_count"` | |||
| SavedSearchesCount string `json:"ss_count"` | |||
| CompletedCount string `json:"completed_count"` | |||
| IncompleteCount string `json:"incomple_count"` | |||
| IncompleteCount string `json:"incomplete_count"` | |||
atoulme
reviewed
Jan 10, 2025
atoulme
reviewed
Jan 10, 2025
atoulme
reviewed
Jan 10, 2025
jsoref
commented
Jan 10, 2025
| @@ -41,7 +41,7 @@ func TestMetricValidation(t *testing.T) { | |||
| expectedError: errors.New("url scheme must be http or https"), | |||
| }, | |||
| { | |||
| desc: "unparseable url", | |||
| desc: "unparsable url", | |||
There was a problem hiding this comment.
from memory this repository is evenly split between [un]pars(e)able. I often don't push in a direction when they're evenly split, and I'm happy to drop, but...
| @@ -20,15 +20,15 @@ type ResourceID string | |||
| // been changes to resource metadata such as Kubernetes labels. | |||
| // An example of how this is used. Let's say we are dealing with a | |||
| // Pod that has the following labels - | |||
| // {"env": "test", "team": "otell", "usser": "bob"}. Now, let's say | |||
| // {"env": "test", "team": "otell", "user_": "bob"}. Now, let's say | |||
There was a problem hiding this comment.
I tend to suggest using _ to indicate "this is intentionally not the correct token" -- otherwise people are forced to think "is this intentionally a typo or accidentally a typo?" -- and in this PR, it's quite rare that things appear to be intentionally misspelled...
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| **This exporter is undergoing major changes right now.** | |||
|
|
|||
| For some time we have been developing the [new Sumo Logic exporter](https://github.com/SumoLogic/sumologic-otel-collector/tree/main/pkg/exporter/sumologicexporter#sumo-logic-exporter) and now we are in the process of moving it into this repository. | |||
| We are in the process of [moving the Sumo Logic exporter into this repository](https://github.com/SumoLogic/sumologic-otel-collector/pull/1601). | |||
There was a problem hiding this comment.
This is a notable change
Comment on lines
+298
to
299
| ## Calculate an extra disk_ops.total metric as number of all read and write operations happened since the last report. | ||
| - action: copy_metrics |
There was a problem hiding this comment.
this is an atypical correction
| @@ -997,7 +997,7 @@ func TestWALOnExporterRoundTrip(t *testing.T) { | |||
| errs := prwe.handleExport(ctx, tsMap, nil) | |||
| assert.NoError(t, errs) | |||
| // Shutdown after we've written to the WAL. This ensures that our | |||
| // exported data in-flight will flushed flushed to the WAL before exiting. | |||
| // exported data in-flight will be flushed to the WAL before exiting. | |||
There was a problem hiding this comment.
another atypical correction
| {"https://doesnotexist.com", "", "https://doesnotexist.com"}, | ||
| {"https://doesnotexist.com", "us", "https://doesnotexist.com"}, | ||
| {"https://doesnotexist.com", "not-valid", "https://doesnotexist.com"}, | ||
| {"https://nonexistent.com", "", "https://nonexistent.com"}, |
There was a problem hiding this comment.
I sometimes encourage people to use RFC 2606 domains in which case this should be https://nonexistent.example.com, but I skipped that step here...
There was a problem hiding this comment.
I agree. Maybe good to track with an other issue.
| @@ -53,7 +53,7 @@ func buildEventFromSpan( | |||
| } | |||
|
|
|||
| attrs["sca:schema"] = "tracing" | |||
| attrs["sca:schemVer"] = 1 | |||
| attrs["sca:schemaVer"] = 1 | |||
There was a problem hiding this comment.
hopefully this is ok...
This was referenced Jan 10, 2025
codeboten
pushed a commit
that referenced
this pull request
Jan 10, 2025
#### Description Fix spelling in processor/ #37128 (review) #### Link to tracking issue * #37128 --------- Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/opentelemetry-collector-contrib/actions/runs/12703384198#summary-35411084604
Testing
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/opentelemetry-collector-contrib/actions/runs/12703386265#summary-35411089865
Merging
I understand this is a bit big... Some of my PRs can be up to ~1k commits, so this is only really a medium size PR by my standards.
It's pretty easy for me to split into series of n commits if that's desired (as long as there aren't too many overlapping commits -- iirc there are a handful, but that's fine, I can leave the conflicting ones off).
Generally I'm quite flexible, but I don't have as much time as I used to, so it's quite possible I won't be able to do much until the middle of next week...