-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common guidance on recording errors on spans and metrics, clarify DB conventions #1716
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (15)
- docs/database/redis.md: Evaluated as low risk
- docs/database/cassandra.md: Evaluated as low risk
- docs/database/cosmosdb.md: Evaluated as low risk
- docs/rpc/rpc-spans.md: Evaluated as low risk
- docs/messaging/messaging-spans.md: Evaluated as low risk
- docs/cli/cli-spans.md: Evaluated as low risk
- docs/http/http-spans.md: Evaluated as low risk
- docs/general/recording-errors.md: Evaluated as low risk
- docs/gen-ai/gen-ai-spans.md: Evaluated as low risk
- docs/faas/faas-spans.md: Evaluated as low risk
- docs/exceptions/README.md: Evaluated as low risk
- docs/database/elasticsearch.md: Evaluated as low risk
- docs/database/database-spans.md: Evaluated as low risk
- docs/database/mongodb.md: Evaluated as low risk
- docs/database/couchdb.md: Evaluated as low risk
4c1fdc3
to
456f377
Compare
@@ -11,33 +11,6 @@ exceptions associated with spans. | |||
|
|||
<!-- toc --> | |||
|
|||
- [Recording an Exception](#recording-an-exception) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a duplicate of the spec doc https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/exceptions.md
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
4558c9c
to
4ddc1d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but we may want to give some vendors extra time to adjust to the new span status guidance.
Fixes #1536
error.type
as generic error attribute on spans and metricsdb.response.status_codes
as failuresImportant
We can and should implement strategy of reporting exceptions on local root spans in OTel SDK - it should not be an instrumentation concern.
Here's an OTEP on how to record exceptions on logs - it discusses the details of configurable exception recording strategy.
Since public facing log API is in development, we'll keep using span events for the time being.
Merge requirement checklist
[chore]