Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove stable requirement from enum rule #1731

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

trisch-me
Copy link
Contributor

Fixes #1686

before the fix with missing enum attribute check policies don't have any error

After the fix

semantic-conventions[main*] % make check-policies
Weaver Registry Check
✔ `main` semconv registry `/home/weaver/source` loaded (172 files)
✔ `baseline` semconv registry `https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.29.0.zip[model]` loaded (171 files)
✔ No `before_resolution` policy violation
✔ `main` semconv registry resolved
✔ No `after_resolution` policy violation
✔ `baseline` semconv registry resolved
✔ All `comparison_after_resolution` policies checked (1 violations found)

Diagnostic report:

Violation: Enum 'gen_ai.system' had member 'vertex_ai', but is no longer defined
  - Category         : backward_compatibility
  - Type             : semconv_attribute
  - SemConv group    : registry.gen_ai
  - SemConv attribute: gen_ai.system
  - Provenance: /home/weaver/source

after adding a deprecated attribute

semantic-conventions[main*] % make check-policies
Weaver Registry Check
✔ `main` semconv registry `/home/weaver/source` loaded (172 files)
✔ `baseline` semconv registry `https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.29.0.zip[model]` loaded (171 files)
✔ No `before_resolution` policy violation
✔ `main` semconv registry resolved
✔ No `after_resolution` policy violation
✔ `baseline` semconv registry resolved
✔ No `comparison_after_resolution` policy violation

@trisch-me trisch-me requested review from a team as code owners January 9, 2025 16:41
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trisch-me
Copy link
Contributor Author

@jsuereth @lmolkova I have extended the test for experimental attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add policy to prevent enum member removal
3 participants