Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests #86844

Merged
merged 1 commit into from
Jan 14, 2025
Merged

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests #86844

merged 1 commit into from
Jan 14, 2025
+10 −0

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Jan 9, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2152

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2152

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Jan 09 12:38:08 - Prow CI generated the docs preview:

https://86844--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_base_install/ibi_deploying_sno_clusters/ibi-edge-image-based-install.html
https://86844--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/image_base_install/ibi_deploying_sno_clusters/ibi-edge-image-based-install-standalone.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2152

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74
Copy link

eranco74 commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@josclark42
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 13, 2025

@josclark42: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-2152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

TELCODOCS-2152: adding note for character limit in IBI deployment with extra manifests

Version(s):
4.17+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2152

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 14, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 14, 2025
@lpettyjo lpettyjo self-requested a review January 14, 2025 13:46
@lpettyjo lpettyjo added this to the Continuous Release milestone Jan 14, 2025
lpettyjo
lpettyjo reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 14, 2025
@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 14, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 14, 2025
jeana-redhat
jeana-redhat approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 14, 2025
@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 14, 2025
@jeana-redhat jeana-redhat merged commit 82f464d into openshift:main Jan 14, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.18

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #86993

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 14, 2025
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #86994

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees

@eranco74 eranco74

Labels
branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @eranco74 @josclark42 @jeana-redhat @openshift-cherrypick-robot @lpettyjo