Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for generating unoptimized debug builds #60666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 6, 2025

Not sure what changes were made recently to the compilers package but I've noticed without undef'ing _FORTIFY_SOURCES that the compiler throws a lot of errors about having that defined with optimizations turned off. Looks like we were also missing flags for C++

I forget where the original conversation was about this, but I'm assuming these flags are never going away with the compilers package. @rgommers does NumPy still use that package or have you moved on to a possibly better solution?

@WillAyd WillAyd requested a review from noatamir as a code owner January 6, 2025 19:31
@rgommers
Copy link
Contributor

rgommers commented Jan 7, 2025

The compilers package is still relevant, and we're using it in NumPy, SciPy and various other places. There is no good alternative yet unfortunately.

I haven't seen this problem yet. Could you add the errors you're seeing and the version/platform of compilers where you started seeing this in a comment or PR description?

@WillAyd
Copy link
Member Author

WillAyd commented Jan 7, 2025

Ah OK - I think I am starting to see the warning as I'm experimenting with some C++ extensions, and the warning seems to come from C++ not C

  /home/willayd/miniforge3/envs/pandas-dev/x86_64-conda-linux-gnu/sysroot/usr/include/features.h:330:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
    330 | #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)

I'll have to do some more research to pinpoint the versions and exact conditions under which this appears, but I'm seeing it on ubuntu 24.04. Looks like the compilers package installs gcc=13.3.0=h9576a4e_1

@mroeschke mroeschke added the Docs label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants