Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP8.4] Document tidy constructor の翻訳 #181

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

asumikam
Copy link
Contributor

@asumikam asumikam commented Nov 22, 2024

refs #150
php/doc-en#3907 の翻訳作業をしました🍥

@asumikam asumikam changed the title 翻訳: Document tidy constructor changes in PHP 8.4 doc-en#3907 [PHP8.4] 翻訳: Document tidy constructor changes in PHP 8.4 doc-en#3907 Nov 22, 2024
@asumikam asumikam changed the title [PHP8.4] 翻訳: Document tidy constructor changes in PHP 8.4 doc-en#3907 [PHP8.4] 翻訳: Document tidy constructor changes in PHP 8.4 Nov 22, 2024
@asumikam asumikam changed the title [PHP8.4] 翻訳: Document tidy constructor changes in PHP 8.4 [PHP8.4] Document tidy constructor changes in PHP 8.4 の翻訳 Nov 22, 2024
@asumikam asumikam changed the title [PHP8.4] Document tidy constructor changes in PHP 8.4 の翻訳 [PHP8.4] Document tidy constructor の翻訳 Nov 22, 2024
@asumikam asumikam force-pushed the tidy-constructor-84 branch from 0047ee8 to 7ce1c2f Compare November 22, 2024 14:06
@asumikam asumikam marked this pull request as ready for review November 22, 2024 14:08
@KentarouTakeda KentarouTakeda added the review wanted Review wanted. Please feel free to comment; anyone is welcome! label Nov 22, 2024
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
Thank you for your first contribution!

LGTMです。チェックアウトのついでに少しだけこちらで調整させて頂きました。

  • EN-Revision の更新
    doc-base ある revcheck.php というツールを使うと:
    revcheck
    このような感じで、原文(英語)の方が新しいファイルを一覧し、新旧コミットIDや差分を調べることができます。このツールが利用するファイル冒頭のコミットID表記を、翻訳完了した原文のリビジョンに更新しました。

    良かったら使ってみて下さい。翻訳時に更新頂けると非常に助かりますが、こちらは必須ではありません!

  • 表現の統一
    「宣言」「実行」で揺れていたので「実行」に統一しました。

@KentarouTakeda KentarouTakeda merged commit 95ff037 into php:master Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted Review wanted. Please feel free to comment; anyone is welcome!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants