New Command pp website webfile get #6424
Conversation
|
Hi @ktskumar thank you for creating yet another PR, we're truly grateful for that. |
Adam-it
added
the
hacktoberfest-accepted
|
@ktskumar I added the |
There was a problem hiding this comment.
Hi @ktskumar, I went through your PR. Let's get some things fixed before we merge this.
| } | ||
|
|
||
| class PpWebSiteWebFileGetCommand extends PowerPlatformCommand { | ||
|
|
There was a problem hiding this comment.
Let's remove this superfluous white line
| ); | ||
| } | ||
|
|
||
| #initValidators(): void { |
There was a problem hiding this comment.
Could we setup Zod here as well? Just like you already did on website weblink list? Do let me know!
| ); | ||
| } | ||
|
|
||
| private async getWebSiteId(dynamicsApiUrl: string, args: CommandArgs): Promise<any> { |
There was a problem hiding this comment.
Website is a single word. Let's cjamge the casing to reflect that:
| private async getWebSiteId(dynamicsApiUrl: string, args: CommandArgs): Promise<any> { | |
| private async getWebsiteId(dynamicsApiUrl: string, args: CommandArgs): Promise<any> { |
| } | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's move private functions to below the commandAction function....
| if (args.options.websiteId) { | ||
| return args.options.websiteId; | ||
| } | ||
| const options: PpWebSiteOptions = { |
There was a problem hiding this comment.
I believe this options object is not really used. Let's remove it.
| responseType: 'json' | ||
| }; | ||
|
|
||
| if (options.name) { |
There was a problem hiding this comment.
Lets use args.options.websiteName... But also let's remove this if-statement.
We know for certain that args.options.websiteName should be filled at this point. Otherwise the validator would throw.
We can use args.options.websiteName! to reflect that certainty where we need to use the parameter.
| } | ||
| } | ||
|
|
||
| private async getWebSiteWebFile(dynamicsApiUrl: string, websiteId: string, options: Options): Promise<any> { |
There was a problem hiding this comment.
| private async getWebSiteWebFile(dynamicsApiUrl: string, websiteId: string, options: Options): Promise<any> { | |
| private async getWebFile(dynamicsApiUrl: string, websiteId: string, options: Options): Promise<any> { |
Also, Let's use a type instead of any.
| responseType: 'json' | ||
| }; | ||
|
|
||
| // let webfileitem: any | null = null; |
There was a problem hiding this comment.
Let's remove these comments.
|
|
||
|
|
||
|
|
||
| // requestOptions.url = `${dynamicsApiUrl}/api/data/v9.1/websitewebfiles?$filter=name eq '${options.name}'`; |
There was a problem hiding this comment.
Let's remove unnecessary white lines and comments.
|
Considering the inactivity period, I'll proceed closing these PR's as stale. Feel free to reopen and rework if you've got the time. But if you do, please request reassignment of the issue so we know you're working on it! Kind regards! |
Closes #6273
Added new command
pp website webfile get