Pattern: Object Algebras #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Referencing both the Wadler problem definition and the Bruno solution definition is perfect. |
|
The description of the problem is straightforward and easy to follow, aside from a few spelling issues 👍. I think the solution code could use some more docstrings and/or comments to help walk through it, though it seems like you weren't finished with this part yet, and weren't necessarily looking for comments for it. |
|
@jemc the code is a pony version of the problem from the referenced paper where its discussed. i'm not sure comments would make much of a difference outside of that context. any thoughts you have on comments to make it more clear would be great. I am planning on having more detail in the discussion section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is going to take a while to write. Opening this for initial comment.
DO NOT MERGE
At this point, I'm looking for feedback on the explanation of the expression problem in the "problem" section.