Expose Reader streamcut to read from given Stream Cut #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
tkaitchuck
requested changes
Feb 23, 2024
src/stream_reader_group.rs
Outdated
| #[cfg(feature = "python_binding")] | ||
| #[pyclass] | ||
| #[derive(Clone)] | ||
| pub(crate) struct ReaderStreamCut { |
There was a problem hiding this comment.
This is a confusing name. StreamCuts are for the whole stream and not specific to a reader. We can call this StreamCut and alias the StreamCut that is being imported to something else
tests/pravega_reader_test.py
Outdated
| if count == 2 : | ||
| break | ||
| self.assertEqual(count, 2, "Two events are expected") | ||
| time.sleep(3) |
There was a problem hiding this comment.
We should not depend on time, especially not in a hard coded way like this. Maybe we could have a #[cfg(test)] method which forces the update
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
tkaitchuck
approved these changes
Feb 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 86.02% 83.50% -2.52%
==========================================
Files 8 8
Lines 880 970 +90
==========================================
+ Hits 757 810 +53
- Misses 123 160 +37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
If Client application crashes and if user wants to continue read from the stream where it left off, currently, there is no method to obtain StreamCuts from the ReaderGroup.
StreamCuts are set of segment/offset pairs for a single stream that represent a consistent position in the stream.
Purpose of the change
Closes #23
What the code does
Exposed get_streamcut() API to return the Stream cut object.
How to verify it
All the testcase should pass