Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove extra arch + refactor unit tests workflow #2

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

bugra-yilmaz
Copy link
Collaborator

@bugra-yilmaz bugra-yilmaz commented Sep 30, 2024

CUDA 12 is not compatible with some of the older GPU architectures, namely:

Allowed values for this option: 'all','all-major','compute_50','compute_52',
'compute_53','compute_60','compute_61','compute_62','compute_70','compute_72',
'compute_75','compute_80','compute_86','compute_87','compute_89','compute_90',
'compute_90a','lto_50','lto_52','lto_53','lto_60','lto_61','lto_62','lto_70',
'lto_72','lto_75','lto_80','lto_86','lto_87','lto_89','lto_90','lto_90a',
'native','sm_50','sm_52','sm_53','sm_60','sm_61','sm_62','sm_70','sm_72',
'sm_75','sm_80','sm_86','sm_87','sm_89','sm_90','sm_90a'.

torch-points-kernels setup file explicitly adds support for the architecture sm_35 for a currently unknown reason (see more context).

This PR removes this additional build flag.

Also, I refactored unit tests workflow to adjust some stuff to our current setup.

The plan is to issue a new release, 0.7.2 after merging this.

@bugra-yilmaz bugra-yilmaz self-assigned this Sep 30, 2024
@bugra-yilmaz bugra-yilmaz changed the title feat: remove extra arch feat: remove extra arch + refactor unit tests workflow Sep 30, 2024
if: ${{matrix.os == 'macos-latest'}}
run: pip install torch==${{ matrix.torch-version }}

pip install "numpy==1.26.4" scikit-learn flake8 setuptools numba

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why are the other dependencies not pinned to a specific version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've received an error from Torch - Numpy interaction and this is the version we have in OSS dependencies currently.

The public repository doesn't have any changes to the unit tests workflow for 2 years - they don't support Python 3.8 yet so I thought this is already much better than what there was 😛

@bugra-yilmaz bugra-yilmaz merged commit 1e52729 into master Sep 30, 2024
6 checks passed
Copy link

@nora-promaton nora-promaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this work with the matrix, did we test for all os x python version x torch versions? And now we only will test with ubuntu latest and torch?


jobs:
unittests:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was not listed as a goal of this PR. Why don't we need macos and windows anymore?

Copy link
Collaborator Author

@bugra-yilmaz bugra-yilmaz Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't run anything on macOS or Windows so I didn't want us to waste time / resources with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants