Add debug log when downscoring a peer for bad response. #14742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
force-pushed
the
debug-log-on-downscore
branch
from
d2aa446 to
d24ecf6
Compare
nalepae
force-pushed
the
debug-log-on-downscore
branch
from
d24ecf6 to
7e71977
Compare
saolyn
reviewed
Jan 15, 2025
Comment on lines
+481
to
+482
| score := s.Peers().Scorers().BadResponsesScorer().Increment(info.ID) | ||
| return errors.Wrapf(err, "connect to peer %s - new bad responses score: %d", info.ID, score) |
There was a problem hiding this comment.
Since we are using score only once would it not be better to just use the value?
Suggested change
| score := s.Peers().Scorers().BadResponsesScorer().Increment(info.ID) | |
| return errors.Wrapf(err, "connect to peer %s - new bad responses score: %d", info.ID, score) | |
| return errors.Wrapf(err, "connect to peer %s - new bad responses score: %d", info.ID, s.Peers().Scorers().BadResponsesScorer().Increment(info.ID)) |
Comment on lines
+211
to
+212
| score := s.p2p.Peers().Scorers().BadResponsesScorer().Increment(ib.blockPid) | ||
| log.WithError(err).WithFields(ib.logFields()).WithField("newBlockPidBadResponsesScore", score).Debug("Backfill batch failed to import") |
Comment on lines
+340
to
+343
| score := q.blocksFetcher.p2p.Peers().Scorers().BadResponsesScorer().Increment(m.pid) | ||
| log. | ||
| WithFields(logrus.Fields{"pid": response.pid, "newBadResponsesScore": score}). | ||
| Debug("Peer is penalized for invalid blocks") |
saolyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
We need to know, when a peer is disconnected for a "too many bad responses" reason, what were these bad responses.
Which issues(s) does this PR fix?
Acknowledgements