Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammatical issues in documentation #14786

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix grammatical issues in documentation #14786

wants to merge 2 commits into from

Conversation

Dahka2321
Copy link

Fix grammatical issues in documentation

Changes:

config/features/README.md:

  • releasing your feature
  • release your feature

Reason: Using correct infinitive form after "to"

config/fieldparams/mainnet.go:

  • MaxBlobCommitmentsPerBlock defines the theoretical limit of blobs can be included in a block.
  • MaxBlobCommitmentsPerBlock defines the theoretical limit of blobs that can be included in a block.
  • defined to match blob.size in bazel ssz codegen
  • Defined to match blob.size in bazel ssz codegen

Reason: Added missing "that" and capitalized comment for consistency

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@Dahka2321 Dahka2321 requested a review from a team as a code owner January 9, 2025 18:06
@Dahka2321 Dahka2321 requested review from saolyn, potuz and nisdas January 9, 2025 18:06
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dahka2321 @CLAassistant