increasing default gas limit #14806
Draft
increasing default gas limit #14806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Jan 16, 2025
| @@ -247,6 +250,10 @@ func (psl *settingsLoader) processProposerSettings(loadedSettings, dbSettings *v | |||
|
|
|||
| // process any builder overrides on defaults | |||
| if newSettings.DefaultConfig != nil { | |||
| if newSettings.DefaultConfig.Builder != nil && newSettings.DefaultConfig.Builder.Enabled && newSettings.DefaultConfig.Builder.GasLimit == 0 && gasLimitOnly == nil { | |||
There was a problem hiding this comment.
this is ugly but not sure where else to do this...
james-prysm
commented
Jan 16, 2025
| @@ -69,6 +69,9 @@ func WithGasLimit() SettingsLoaderOption { | |||
| log.Warnf("Gas limit was intentionally set to 0, this will be replaced with the default gas limit of %d", params.BeaconConfig().DefaultBuilderGasLimit) | |||
| } | |||
| rgl := reviewGasLimit(validator.Uint64(gl)) | |||
| if &rgl != nil { | |||
| log.Infof("Using a global gas limit of %d if builder is enabled", rgl) | |||
There was a problem hiding this comment.
maybe need to lowercase , how does this sound?
There was a problem hiding this comment.
What do you mean "if builder is enabled"? Can we check if it is enabled?
james-prysm
commented
Jan 16, 2025
| @@ -247,6 +250,10 @@ func (psl *settingsLoader) processProposerSettings(loadedSettings, dbSettings *v | |||
|
|
|||
| // process any builder overrides on defaults | |||
| if newSettings.DefaultConfig != nil { | |||
| if newSettings.DefaultConfig.Builder != nil && newSettings.DefaultConfig.Builder.Enabled && newSettings.DefaultConfig.Builder.GasLimit == 0 && gasLimitOnly == nil { | |||
There was a problem hiding this comment.
also need to add unit tests
james-prysm
commented
Jan 16, 2025
| @@ -263,7 +263,7 @@ var mainnetBeaconConfig = &BeaconChainConfig{ | |||
| TerminalBlockHash: [32]byte{}, | |||
| TerminalTotalDifficulty: "58750000000000000000000", // Estimated: Sept 15, 2022 | |||
| EthBurnAddressHex: "0x0000000000000000000000000000000000000000", | |||
| DefaultBuilderGasLimit: uint64(30000000), | |||
| DefaultBuilderGasLimit: uint64(36000000), | |||
There was a problem hiding this comment.
is this number correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements