gh-128156: Guard use of ffi_type_complex_double on macOS system libffi
#128680
+110
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Jan 10, 2025
| TABLE_ENTRY(C, &ffi_type_complex_double); | ||
| TABLE_ENTRY(E, &ffi_type_complex_float); | ||
| TABLE_ENTRY(F, &ffi_type_complex_longdouble); | ||
| if (Py_FFI_COMPLEX_AVAILABLE) { |
There was a problem hiding this comment.
Maybe you rather should move all runtime logic for Py_FFI_COMPLEX_AVAILABLE to this place, together with a comment why (and when) we need this. And when it might be removed.
There was a problem hiding this comment.
I don't want to imply that this needs to be the only place that uses the runtime check.
IMO, the __builtin_available(macOS 10.15, *) already indicates that it can be removed when we drop macOS 10.14 and lower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formattable.fmt{C,E,F}now have a runtime guard (ifUSING_APPLE_OS_LIBFFI).The list of type codes (previously
SIMPLE_TYPE_CHARS) is now generated at runtime.ffi_type_complex_doubleis unguarded #128156📚 Documentation preview 📚: https://cpython-previews--128680.org.readthedocs.build/