-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UTF-8 data when using the JSON serializer #39
Support UTF-8 data when using the JSON serializer #39
Conversation
The specs don't cover the setup V1 encryptor+JSON serializer. I feel this is OK now, as the V1 encryptor is battle-tested. I'm happy to hear otherwise. Somewhat related: assuming that most use the default V1 serializer - Marshal - it's important to note that the JSON serializer can introduce subtle changes. A key one is that it transforms symbols into strings. This leads me to the question: should we default to the V2 encryptor in the next release or make it opt-in instead? |
We could consider using |
218d5e0
to
aae5ea4
Compare
We could. The bigger point is that small differences are unavoidable. We could also support |
Thanks for persisting with this, I'll review it today. |
* Replace all instance of 'BINARY' with `Encoding::BINARY`
Closes #38