Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify-codeowners hook #60

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Add verify-codeowners hook #60

merged 9 commits into from
Jan 24, 2025

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jan 9, 2025 •
edited by vyasr
Loading

Resolves #61

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners January 9, 2025 23:45
gforsyth
gforsyth reviewed Jan 10, 2025
View reviewed changes
Copy link

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KyleFromNVIDIA ! I think this looks pretty good -- the design pattern seems solid generally, and I think we'll find out if anything in particular is going to cause trouble once we add a few extra rules.

I've left a few comments inline, none of them blocking, just some nits and suggestions.

src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
gforsyth
gforsyth reviewed Jan 13, 2025
View reviewed changes
Copy link

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small idiomatic change

src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jan 14, 2025

Before I review this, I created #61 to decide what rules we want enforced.

@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jan 16, 2025
Closed
vyasr
vyasr reviewed Jan 24, 2025
View reviewed changes
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
src/rapids_pre_commit_hooks/codeowners.py Outdated Show resolved Hide resolved
vyasr
vyasr requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great overall, thanks Kyle! I have some suggestions for hopefully simplifying and improving the code.

vyasr
vyasr approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed up on two open threads, but nothing blocking at this point so I'm preapproving.

@KyleFromNVIDIA KyleFromNVIDIA merged commit 9a7c590 into rapidsai:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth left review comments

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hook to lint CODEOWNERS files
3 participants
@KyleFromNVIDIA @vyasr @gforsyth