Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable exec checks for device_uvector::operator= #1790

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jan 23, 2025

We already suppress those for the constructors

@miscco miscco requested a review from a team as a code owner January 23, 2025 12:18
@miscco miscco requested review from rongou and jrhemstad January 23, 2025 12:18
@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 23, 2025
@miscco miscco requested a review from bdice January 23, 2025 12:18
@miscco miscco added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 23, 2025
We already suppress those for the constructors
@miscco miscco force-pushed the add_exec_check_disable_uvector branch from 8c4fde9 to 4c732d0 Compare January 23, 2025 12:45
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks

@bdice
Copy link
Contributor

bdice commented Jan 23, 2025

We had the same change proposed in #1786 but we don’t have any tests for this case. Can you share how you found this, and help us minimize it into a test so we don’t miss this anywhere else?

@miscco
Copy link
Contributor Author

miscco commented Jan 23, 2025

That was a fallout from building rapids, where rmm::device_vector was stored in a rmm::device_uvector

@bdice
Copy link
Contributor

bdice commented Jan 23, 2025

Docs builds are failing:

 /__w/rmm/rmm/python/rmm/docs/librmm_docs/data_containers.rst:4: WARNING: Error when parsing function declaration.
If the function has no return type:
  Error in declarator or parameters-and-qualifiers
  Invalid C++ declaration: Expecting "(" in parameters-and-qualifiers. [error at 23]
    RMM_EXEC_CHECK_DISABLE device_uvector & operator= (device_uvector &&) noexcept=default
    -----------------------^
If the function has a return type:
  Error in declarator or parameters-and-qualifiers
  If pointer to member declarator:
    Invalid C++ declaration: Expected '::' in pointer to member (function). [error at 38]
      RMM_EXEC_CHECK_DISABLE device_uvector & operator= (device_uvector &&) noexcept=default
      --------------------------------------^
  If declarator-id:
    Invalid C++ declaration: Expecting "(" in parameters-and-qualifiers. [error at 38]
      RMM_EXEC_CHECK_DISABLE device_uvector & operator= (device_uvector &&) noexcept=default
      --------------------------------------^

I'd also like to get a test that reproduces the previous failure into this PR if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants