Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-remix): set fs-extra as dependency #10300

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

KnisterPeter
Copy link
Contributor

fs-extra is used by the create-remix cli as a runtime dependency, therefore this change does move it from devDependency to dependency.

Closes #10299

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 9acd160

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/fs-routes Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 4, 2024

Hi @KnisterPeter,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 4, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@KnisterPeter
Copy link
Contributor Author

@brophdawg11 @brookslybrand Do have time to review this bugfix? Currently the create-remix package is broken.

@brophdawg11
Copy link
Contributor

Thank you for the PR! Would you mind repointing this to dev since it's a code change?

@brookslybrand brookslybrand changed the base branch from main to dev December 4, 2024 16:22
@KnisterPeter
Copy link
Contributor Author

Updated and rebased.

`fs-extra` is used by the create-remix cli as a runtime dependency,
therefore this change does move it from devDependency to dependency.

Closes remix-run#10299
@andreibade
Copy link

This should be merged ASAP

@brookslybrand brookslybrand merged commit 9bc6d95 into remix-run:dev Dec 5, 2024
9 checks passed
@syakirurahman
Copy link

When will this be released?

@iltan987
Copy link

iltan987 commented Dec 6, 2024

Having this issue. Please fix

@gowy222
Copy link

gowy222 commented Dec 7, 2024

When will this be released? --ASAP

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🤖 Hello there,

We just published version 2.15.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🤖 Hello there,

We just published version 2.15.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install/get started with remix
7 participants