Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing NHL unit test
The file test_nhl_roster.py failed one of the tests. The error seems to be that the test expects the method player._retrieve_html_page() to return None, but instead, it's returning a list containing an HTML paragraph element ([
]). Mismatch between expected and actual outputs leads to the assertion failure.
Signed-Off-By: Scott [email protected]
Pull Request template
Please, go through these steps before you submit a Pull Request (PR).
unrelated updates.
functionality are included.
in the
docs/
directory when appropriate.closes #XXXX
in your comment to auto-close any issue(s) your PRresolves, if applicable.
IMPORTANT: Please review the CONTRIBUTING.md file for
detailed contributing and styling guidelines.
PLEASE REMOVE THIS TEMPLATE PRIOR TO SUBMITTING THE PULL REQUEST