Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain some more details of the triage procedure #766

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

lolbinarycat
Copy link
Contributor

based on discussion with @Dylan-DPC

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Dylan-DPC (or someone else) some time within the next two weeks.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2024
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, mostly nitpicks.

after them, it looks good to me.

@jieyouxu
Copy link
Member

jieyouxu commented Dec 10, 2024

Addressed the feedback

@jieyouxu jieyouxu requested a review from apiraino December 10, 2024 04:28
@jieyouxu jieyouxu self-assigned this Dec 10, 2024
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted just tiny nits that I will apply myself

@apiraino apiraino merged commit 6dd73e2 into rust-lang:master Dec 10, 2024
1 check passed
@apiraino
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants