Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue triaging docs #794

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jan 5, 2025

  • Document more labels.
  • Further clarify / adjust some triage flows.

Rendered

cc @rust-lang/wg-triage

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

r? @pietroalbini

rustbot has assigned @pietroalbini.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 5, 2025

@traviscross also while you're here... Do you know if some of the tracking issue labels S-tracking-* are only used by T-lang?

src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
@traviscross
Copy link
Contributor

@traviscross also while you're here... Do you know if some of the tracking issue labels S-tracking-* are only used by T-lang?

There are some that are only or mostly used for the edition, at the moment, e.g.:

  • S-tracking-ready-for-edition
  • S-tracking-needs-migration-lint
  • S-tracking-at-risk

Looking at the others, there are ones like S-tracking-ready-to-stabilize that seem most often used by lang, but there's no particular reason they might not be used by others.

Copy link
Contributor

@oskgo oskgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it comes to making markdown diffs nicer to view I've found the rich diff to be quite good. You still need to use the source diff for requesting changes though.

Nice work!

src/release/issue-triaging.md Outdated Show resolved Hide resolved
@matthiaskrgr
Copy link
Member

(I don't know how to make markdown diffs nice to review, sorry)

what people often do is include the link to the full, rendered md preview of their own repo, like so:
https://github.com/jieyouxu/rust-forge/blob/label-advice/src/release/issue-triaging.md

Rendered
[Rendered](https://github.com/jieyouxu/rust-forge/blob/label-advice/src/release/issue-triaging.md)

src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
Copy link
Contributor

@apiraino apiraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow some serious bikeshedding happening here. I've added mine 🙂

thanks @jieyouxu for this effort!

src/release/issue-triaging.md Outdated Show resolved Hide resolved
src/release/issue-triaging.md Outdated Show resolved Hide resolved
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2025
@jieyouxu jieyouxu force-pushed the label-advice branch 3 times, most recently from 04186bb to b3095d5 Compare January 6, 2025 13:39
@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 6, 2025

@traviscross also while you're here... Do you know if some of the tracking issue labels S-tracking-* are only used by T-lang?

There are some that are only or mostly used for the edition, at the moment, e.g.:

  • S-tracking-ready-for-edition
  • S-tracking-needs-migration-lint
  • S-tracking-at-risk

Looking at the others, there are ones like S-tracking-ready-to-stabilize that seem most often used by lang, but there's no particular reason they might not be used by others.

Thanks for the info. I left out the S-tracking-* ones because I'm not actually sure what they are intended to be used for (could probably be in a follow-up after we figure out what they're actually intended for).

@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 6, 2025

I believe I've addressed (most of) the existing feedback.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2025
@jieyouxu jieyouxu added T-compiler Team: Compiler T-release Team: Release labels Jan 6, 2025
@Noratrieb Noratrieb merged commit 7a79750 into rust-lang:master Jan 6, 2025
1 check passed
@jieyouxu jieyouxu deleted the label-advice branch January 6, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Team: Compiler T-release Team: Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.