Fix Serial Write #23
Draft
Fix Serial Write #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to guarantee the width of the start bit in a serial transfer we need ot make sure that we are waiting for the correct amount of time. Since the timer is already started we have no guarantee of the current count value and therefore should add an initial wait.
Javier-varez
force-pushed
the
fix_serial_write
branch
from
52b77b9 to
12bf17f
Compare
|
I would rather take the solution in #10 but it needs to be updated to support embedded-time. Would you be able to take that on? |
|
I fully agree, that would be a much better solution. I'll give it a go! |
|
I'm not quite sure I understand the strategy to use the embedded time crate. As far as I have seen no timer hardware abstraction layers currently use the types and traits defined there, so the serial port will not work with them? |
|
I was under the impression there was better adoption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to guarantee the width of the start bit in a serial transfer we
need ot make sure that we are waiting for the correct amount of time.
Since the timer is already started we have no guarantee of the current
count value and therefore should add an initial wait.