Cppcheck #49

charlesUnixPro · 2018-12-06T23:31:29Z

Fix 'cppcheck' errors; add two va_end() calls on error exit.

Release 0.23

thefallentree · 2018-12-13T16:04:04Z

+1

thefallentree

actually, because va2 is not va_started , so it doesn't need to be va_end-ed.

Shea690901

Excerpt from man va_copy:

Each invocation of va_copy() must be matched by a corresponding invocation of va_end() in the same function.

So this change is needed, but it is missing the va_end(va) for the original va_start(va)...

Shea690901 · 2022-05-29T19:04:02Z

libtelnet.c

@@ -1482,6 +1482,7 @@ int telnet_vprintf(telnet_t *telnet, const char *fmt, va_list va) {
 		if (output == 0) {
 			_error(telnet, __LINE__, __func__, TELNET_ENOMEM, 0,
 					"malloc() failed: %s", strerror(errno));
+			va_end(va2);


Missing va_end(va);
The same with the change further down....

Sean Middleditch and others added 2 commits October 17, 2018 23:18

Merge pull request seanmiddleditch#45 from seanmiddleditch/develop

c979e8a

Release 0.23

Fix 'cppcheck' errors: add two calls to va_end() on error exit.

22b0633

thefallentree approved these changes Jan 6, 2019

View reviewed changes

thefallentree suggested changes Jan 6, 2019

View reviewed changes

Shea690901 suggested changes May 29, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cppcheck #49

Cppcheck #49

charlesUnixPro commented Dec 6, 2018

thefallentree commented Dec 13, 2018

thefallentree left a comment

Shea690901 left a comment

Shea690901 May 29, 2022 •

edited

Loading

Cppcheck #49

Are you sure you want to change the base?

Cppcheck #49

Conversation

charlesUnixPro commented Dec 6, 2018

thefallentree commented Dec 13, 2018

thefallentree left a comment

Choose a reason for hiding this comment

Shea690901 left a comment

Choose a reason for hiding this comment

Shea690901 May 29, 2022 • edited Loading

Choose a reason for hiding this comment

Shea690901 May 29, 2022 •

edited

Loading